-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix duplicate episode sc send lca #881
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view, the 📜action log, or 📝 job summary for details. Unrecognized words (2)beddays To accept these unrecognized words as correct, you could run the following commands... in a clone of the [email protected]:Public-Health-Scotland/source-linkage-files.git repository curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' |
perl - 'https://github.com/Public-Health-Scotland/source-linkage-files/actions/runs/7196864349/attempts/1' OR To have the bot accept them for you, reply quoting the following line: Errors (2)See the 📂 files view, the 📜action log, or 📝 job summary for details.
See ❌ Event descriptions for more information. If the flagged items are 🤯 false positivesIf items relate to a ...
|
See the create_episode_file,
line 34,
episode_file <- dplyr::bind_rows(processed_data_list) %>%
, thebind_rows
matched all episode records by chi, sending_location, sc_send_lca, etc.line 37,
store_ep_file_vars(
drops not very necessary columns/variables, includingsc_send_lca
, and will join back at line 137.line 136,
join_sc_client(year, sc_client = sc_client, file_type = "episode") %>%
add sc_send_lca column again, which cause two sc_send_lca columns.Since line 136 only matches by sending_location, it seems not as reliable as line 34. I prefer to drop
sc_send_lca
column added by line 136. Feel free to comment.